containers: Catch decode_json() exception in engine->info() #20878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobranco777
requested review from
pdostal,
grisu48,
mloviska and
rbmarliere
as code owners
ricardobranco777
force-pushed
the
json
branch
from
64edf14 to
10cb010
Compare
ricardobranco777
force-pushed
the
json
branch
from
10cb010 to
85b6e78
Compare
ricardobranco777
changed the title
asmorodskyi
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
commit message/ PR message a bit misleading . unless I have missed something you didn't "fix" anything . You add more verbosity to the error in case of decode_json error. Can you please tweak commit/PR message to something like "Add more verbosity to decode_json errors" ? other than that LGTM
ricardobranco777
force-pushed
the
json
branch
from
85b6e78 to
9374574
Compare
ricardobranco777
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code doesn't catch JSON exceptions and the content of stderr is never shown.