Include GPU check validation #20840
Include GPU check validation #20840
Conversation
yarunachalam
requested review from
pdostal,
grisu48,
asmorodskyi,
ricardobranco777,
m-dati and
rbmarliere
as code owners
yarunachalam
force-pushed
the
gpucheck
branch
from
3202a12 to
99aee72
Compare
| my @out = split(' ', script_output("kubectl get pods --namespace $namespace -o custom-columns=':metadata.name'")); | ||
| record_info("Pod names", join(" ", @out)); | ||
| POD_LOOP: foreach my $pod (@out) { | ||
|
|
||
| if ($pod =~ /^ollama/) { | ||
| $ollama_pod = $pod; |
There was a problem hiding this comment.
If you expect 1 only possible ollama pod, then all is ok.
Is there any possiblity that get pods would return 2 or more? In that case you'd store last one only, so, be sure that 1 only is possible here, unless even multiple are equivalent.
| @@ -188,6 +194,25 @@ sub install_aistack_chart { | |||
| } # pod loop | |||
There was a problem hiding this comment.
In this point, having you detected eventual errors in pod or logs, it'd be better to soon report here issues and react on that.
Therefore I'd suggest to move here your checks performed below at lines from 211 to 218.
Moreover, also cosider if needed to exit on error detected in log pod: but up to you, based on system requirements.
There was a problem hiding this comment.
Please also consider an update as by suggestions in the previous PR #20723 (comment), related to Lines here starting from L261 up to L278
Do not exist for log issues only pod failure.
yarunachalam
force-pushed
the
gpucheck
branch
from
99aee72 to
90db577
Compare
Include GPU check validation for NVIDIA test flavor