ipsecbase.pm: check firewall status before stop firewall #20825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
czerw
reviewed
Dec 17, 2024
| unless (systemctl "is-active apparmor", ignore_failure => 1) { # 0 if active, unless to revert | ||
| systemctl "disable --now apparmor"; | ||
| record_info "apparmor", "disabled"; | ||
| sub ensure_service_disabled { |
There was a problem hiding this comment.
Looks like generic function. It would make sense to put it in some utils. @dzedro could you please recommend some place?
That's fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipsecbase.pm: check firewall status before stop firewall
15sp7 regression VR
https://openqa.suse.de/tests/16213766
sle-16.0 VR
https://openqa.suse.de/tests/16212667
NOTE:
sle-16.0 repo has no tcpdump lead following error:
https://openqa.suse.de/tests/16212665#step/ipsec3hosts/97