Skip to content

Commit

Permalink
Merge pull request #20415 from Amrysliu/jsc_9699
Browse files Browse the repository at this point in the history
Only create and assign permission for MSI
  • Loading branch information
alvarocarvajald authored Oct 17, 2024
2 parents 5ac10cf + ded29a2 commit c53b85b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/sles4sap/publiccloud/qesap_ansible.pm
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ sub run {
my $instances = create_instance_data(provider => $provider_instance);
foreach my $instance (@$instances) {
record_info 'New Instance', join(' ', 'IP: ', $instance->public_ip, 'Name: ', $instance->instance_id);
if (get_var('FENCING_MECHANISM') eq 'native' && $provider eq 'AZURE') {
if (get_var('FENCING_MECHANISM') eq 'native' && $provider eq 'AZURE' && !check_var('AZURE_FENCE_AGENT_CONFIGURATION', 'spn')) {
qesap_az_setup_native_fencing_permissions(
vm_name => $instance->instance_id,
resource_group => qesap_az_get_resource_group());
Expand Down
2 changes: 1 addition & 1 deletion tests/sles4sap/publiccloud/qesap_terraform.pm
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ sub run {
# We expect hostnames reported by terraform to match the actual hostnames in Azure and GCE
die "Expected hostname $expected_hostname is different than actual hostname [$real_hostname]"
if ((is_azure() || is_gce()) && ($expected_hostname ne $real_hostname));
if (get_var('FENCING_MECHANISM') eq 'native' && get_var('PUBLIC_CLOUD_PROVIDER') eq 'AZURE') {
if (get_var('FENCING_MECHANISM') eq 'native' && get_var('PUBLIC_CLOUD_PROVIDER') eq 'AZURE' && !check_var('AZURE_FENCE_AGENT_CONFIGURATION', 'spn')) {
qesap_az_setup_native_fencing_permissions(
vm_name => $instance->instance_id,
resource_group => qesap_az_get_resource_group());
Expand Down
2 changes: 1 addition & 1 deletion tests/sles4sap/qesapdeployment/deploy.pm
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ sub run {
upload_logs($inventory, failok => 1);

# Set up azure native fencing
if (get_var('QESAPDEPLOY_FENCING') eq 'native' && $provider eq 'AZURE') {
if (get_var('QESAPDEPLOY_FENCING') eq 'native' && $provider eq 'AZURE' && !check_var('AZURE_FENCE_AGENT_CONFIGURATION', 'spn')) {
my @nodes = qesap_get_nodes_names(provider => $provider);
foreach my $host_name (@nodes) {
if ($host_name =~ /hana/) {
Expand Down

0 comments on commit c53b85b

Please sign in to comment.