Adressing commments from codereview

.gitignore

@@ -1,4 +1,3 @@
-.perltidyrc
 *.tdy
 .*.swp
 *~

lib/OpenQA/Test/PatchDeparse.pm

@@ -1,6 +1,4 @@
 package OpenQA::Test::PatchDeparse;
-use strict;
-use warnings 'all';
 use Test::Most;
 
 # Monkeypatch B::Deparse

lib/OpenQA/Test/TimeLimit.pm

@@ -2,8 +2,6 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 package OpenQA::Test::TimeLimit;
-use strict;
-use warnings 'all';
 use Test::Most;
 
 my $SCALE_FACTOR = $ENV{OPENQA_TEST_TIMEOUT_SCALE_FACTOR} // 1;

tools/perlcritic

@@ -4,22 +4,16 @@
 #
 # perlcritic with auto-injection of custom perlcritic rules.
 use strict;
-use warnings 'all';
-use Cwd qw(abs_path getcwd);
-use File::Basename 'dirname';
-use File::Spec::Functions 'catfile';
+use warnings;
+use FindBin '$Bin';
 
 sub extra_include_paths {
     my @extra_paths = @_;
-    # using abs_path without arguments so symlinks are not resolved.
-    # dirname twice to go from `$prj_root/tools/tidyall` to: `$proj_root`
-    my $prj_root = dirname dirname catfile(abs_path(), __FILE__);
 
     my @paths = ();
-
     foreach my $path (@extra_paths) {
-        push @paths, catfile($prj_root, $path);
-        push @paths, catfile($prj_root, "external/os-autoinst-common", $path);
+        push @paths, "$Bin/../$path";
+        push @paths, "$Bin/../external/os-autoinst-common/$path";
     }
 
     # Remove non existing paths

tools/tidyall

@@ -15,16 +15,16 @@ Grabs the perltidy version from cpanfile using Module::CPANfile.
 =cut
 
 sub perltidy_version {
-    $_ = Module::CPANfile->load('cpanfile')
+    my $version = Module::CPANfile->load('cpanfile')
       ->prereq_for_module('Perl::Tidy')
       ->requirement
       ->version;
     # Version requirements may contain qualifiers >=, ==, <, etc. The convention
     # is to separate the qualifier from the actual version with a space.
     #
     # It's safe enough to assume that the last item is really the version.
-    @_ = split(' ', $_);
-    return pop();
+    my @version_components = split(' ', $version);
+    return pop(@version_components);
 }
 
 sub is_force_flag { $_ eq '--force' }

tools/update-deps

@@ -3,8 +3,8 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 use strict;
-use warnings 'all';
-use 5.26;
+use warnings;
+use 5.010;
 
 use YAML::PP;
 use Data::Dumper;