Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make openqa-mon testable again 😸 #143

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Apr 22, 2024

partially tackling #28 , added some unit tests as a starting point for command line parsing validation

@ilmanzo ilmanzo force-pushed the add-tests-on-openqa-mon branch from 57cff12 to bc108af Compare April 22, 2024 10:21
Signed-off-by: Andrea Manzini <[email protected]>
@ilmanzo ilmanzo force-pushed the add-tests-on-openqa-mon branch from bc108af to 13617fc Compare April 22, 2024 10:23
Copy link
Collaborator

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ilmanzo for the contribution! One minor suggestion, otherwise LGTM.

cmd/openqa-mon/openqa-mon_test.go Show resolved Hide resolved
Signed-off-by: Andrea Manzini <[email protected]>
@ilmanzo ilmanzo force-pushed the add-tests-on-openqa-mon branch from e4cbfa8 to 0c3dfd5 Compare April 23, 2024 07:27
@grisu48
Copy link
Collaborator

grisu48 commented Apr 23, 2024

Thank you!

@grisu48 grisu48 merged commit dfe372e into os-autoinst:main Apr 23, 2024
@ilmanzo ilmanzo deleted the add-tests-on-openqa-mon branch April 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants