Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Vowels & NoVowels to the AlphaUpper charsets #749

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: add Vowels & NoVowels to the AlphaUpper charsets #749

merged 1 commit into from
Nov 29, 2023

Conversation

supercairos
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@supercairos supercairos changed the title feat: Add Vowels & NoVowels to the AlphaUpper charsets feat: add Vowels & NoVowels to the AlphaUpper charsets Nov 28, 2023
@supercairos supercairos mentioned this pull request Nov 28, 2023
Open
6 tasks
@supercairos
Copy link
Contributor Author

This is linked to ory/fosite#701

poke @hperl

hperl
hperl approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hperl hperl enabled auto-merge (squash) November 29, 2023 06:20
@hperl hperl merged commit 5616e97 into ory:master Nov 29, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hperl hperl hperl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supercairos @hperl