Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Requested Scopes in Webhook Requests #3891

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

3schwartz
Copy link

Add requested scopes to the webhook request, allowing the webhook to condition access based on the scopes requested by the user.

Related issue(s)

Fixes #3620, particularly implementing the idea proposed in this comment: #3620 (comment).

If this PR is accepted, I can provide an update to the documentation.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (e278b40) to head (e830579).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3891   +/-   ##
=======================================
  Coverage   73.28%   73.29%           
=======================================
  Files         139      139           
  Lines       10914    10933   +19     
=======================================
+ Hits         7998     8013   +15     
- Misses       2377     2384    +7     
+ Partials      539      536    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3schwartz
Copy link
Author

Hi @aeneasr, @hperl, @alnr,

Would any of you have some time to take a look at this? I’d really appreciate your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oauth2 webhook: granted_scopes always empty
1 participant