Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client query negation #3805

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

awill1988
Copy link
Contributor

@awill1988 awill1988 commented Jul 25, 2024

👋🏻 I am new here so I apologize in advance for what is likely a contribution that needs work so I am happy to take plenty of feedback and work towards whatever solution makes the most sense.

The goal of this is to add a concise (and safe) way to specify some negative matching criteria on the HTTP API by expanding the way the query parameters are interpreted when requesting a list of OAuth2 Clients.

Related issue(s)

#3804

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Before I forget to mention it, thank you for this wonderful software!

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
All committers have signed the CLA.

@awill1988 awill1988 force-pushed the feat-client-query-negation branch from 500a2e0 to b45486c Compare July 26, 2024 15:24
@awill1988 awill1988 marked this pull request as ready for review July 26, 2024 15:25
@awill1988 awill1988 requested review from aeneasr, hperl and alnr as code owners July 26, 2024 15:25
@awill1988 awill1988 force-pushed the feat-client-query-negation branch 3 times, most recently from f7f8fcd to 18295d4 Compare July 30, 2024 16:51
@awill1988 awill1988 force-pushed the feat-client-query-negation branch from 18295d4 to aca1c66 Compare August 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants