feat: add support for none response_type #776
Open
+255
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
none
response_type specified in https://openid.net/specs/oauth-v2-multiple-response-types-1_0.html#noneRelated Issue or Design Document
This was brought up before here #409
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments
I still need to add non-unit tests but I'd prefer to do this after I've received confirmation that this feature and this approach is okay. This is also quite a small feature so perhaps extensive testing of it is not completely necessary - please let me know how much testing you're expecting for this!
I also need to add something to the changelog.