Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing translations to ComponentWrapper #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmeijboom
Copy link

This PR allows users to pass custom translations to markup components using the ComponentWrapper.

Related Issue or Design Document

Fixes #166

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (a5fcd44) to head (b955e6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   59.43%   59.43%           
=======================================
  Files          68       68           
  Lines         927      927           
  Branches      129      129           
=======================================
  Hits          551      551           
  Misses        371      371           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dmeijboom dmeijboom changed the title Allow passing translations to ComponentWrapper feat: allow passing translations to ComponentWrapper Nov 19, 2024
@dmeijboom dmeijboom force-pushed the feat/allow-passing-translations-to-ComponentWrapper branch from 1e08248 to 1b07618 Compare November 19, 2024 09:38
@dmeijboom dmeijboom force-pushed the feat/allow-passing-translations-to-ComponentWrapper branch from 1b07618 to b955e6f Compare November 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation / Add support for custom translations in @ory/elements-markup
1 participant