Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tabs aria issues #341

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Fix/tabs aria issues #341

merged 3 commits into from
Oct 3, 2024

Conversation

KitoC
Copy link
Contributor

@KitoC KitoC commented Oct 2, 2024

What this PR does, and why

There were issues with aria attributes on the ActionsMenu and wrapping the customTriggerComponent in a div. This adds the ability to pass in a CustomTriggerComponent component which must have the ref forwarded with React.forwardProps

deividasm
deividasm previously approved these changes Oct 2, 2024
View reviewed changes
lib/components/ActionsMenu/index.js Outdated Show resolved Hide resolved
@KitoC KitoC requested a review from deividasm October 2, 2024 23:38
@KitoC KitoC merged commit 83d5e85 into master Oct 3, 2024
7 checks passed
@KitoC KitoC deleted the fix/tabs_aria_issues branch October 3, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaranAtTeamForm KaranAtTeamForm KaranAtTeamForm approved these changes

@jackthecodemonkey jackthecodemonkey jackthecodemonkey approved these changes

@deividasm deividasm Awaiting requested review from deividasm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KitoC @deividasm @jackthecodemonkey @KaranAtTeamForm