Skip to content

Commit

Permalink
TPP-943 tab aria issues (#342)
Browse files Browse the repository at this point in the history
  • Loading branch information
KitoC authored Oct 8, 2024
1 parent 83d5e85 commit 96180a7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion lib/components/Tabs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ const Tabs = ({ tabsList }) => {
return (
<TabsContainer>
<TabWrapper>
<VisibleTabs style={{ gap: tabsGap }} ref={containerRef}>
<VisibleTabs style={{ gap: tabsGap }} ref={containerRef} role="tablist">
{visibleTabsList.map((tab, i) => (
<Tab
className={tab.className}
Expand All @@ -212,19 +212,22 @@ const Tabs = ({ tabsList }) => {
key={tab.path}
tabInShowMore={showMoreTabs.includes(i)}
to={tab.path}
role="tab"
>
{tab.label}
</Tab>
))}

<ActionsMenu
direction="bottom-end"
role="presentation"
renderTrigger={(props) => (
<ShowMoreButton
{...props}
showMoreVisible={showMoreTabsList.length}
id="show-more-button"
className={showMoreItemActive && "hasActive"}
role="tab"
>
<FlexItem flex="0 0 auto">More</FlexItem>
<FlexItem flex="0 0 auto">
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "orcs-design-system",
"version": "3.2.42",
"version": "3.2.43",
"engines": {
"node": "20.12.2"
},
Expand Down

0 comments on commit 96180a7

Please sign in to comment.