Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Ensure generated testbench.yaml is configured with App\\ and Database\\ instead of Workbench\App\\ and Workbench\Database\\ based on configured namespaces #63

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

crynobone
Copy link
Member

No description provided.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone added enhancement New feature or request dx labels Dec 14, 2024
@coveralls
Copy link

coveralls commented Dec 14, 2024

Coverage Status

coverage: 92.965% (+0.1%) from 92.833%
when pulling 37a3183 on 7/feat-62
into b8a5531 on 7.x.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone changed the title Ensure generated testbench.yaml is configured with App\\ and Database\\ instead of Workbench\App\\ and Workbench\Database\\ based on configured namespaces [7.x] Ensure generated testbench.yaml is configured with App\\ and Database\\ instead of Workbench\App\\ and Workbench\Database\\ based on configured namespaces Dec 14, 2024
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone marked this pull request as ready for review December 14, 2024 03:40
@crynobone crynobone merged commit 9ca758c into 7.x Dec 14, 2024
21 checks passed
@crynobone crynobone deleted the 7/feat-62 branch December 14, 2024 03:40
@sergkulich
Copy link

Hello,

Just checked out this new feature and wonder if the Workbench\ namespace prefix was left intentionally in all classes inside directories
workbench/app/
workbench/database/factories/
workbench/database/seeders/

Running vendor/bin/testbench workbench:build exits with 255 code without any error to display.

Meanwhile running vendor/bin/testbench make:user-model creates the User class in the App\Models namespace.

Thank you

@crynobone
Copy link
Member Author

namespace will be based on configured value in composer.json. If you have any issue submit a bug report with reproducing code + composer.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx enhancement New feature or request
Projects
None yet
3 participants