wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>
orchestral · Dec 10, 2024 · be7b393 · be7b393
2 parents 41386cf + 87a5aca
commit be7b393
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 55 deletions.
diff --git a/CHANGELOG-7.x.md b/CHANGELOG-7.x.md
@@ -2,6 +2,27 @@
 
 This changelog references the relevant changes (bug and security fixes) done to `orchestra/workbench`.
 
+## 7.14.0
+
+Released: 2024-12-10
+
+### Added
+
+* Add `sync-skeleton` and `purge-skeleton` recipe for `workbench:build` command.
+* Set default `laravel` configuration to either `@testbench` or `@testbench-dusk`
+* Added following classes to interacts with Composer:
+    - `Orchestra\Workbench\Actions\DumpComposerAutoloads`
+    - `Orchestra\Workbench\Actions\ModifyComposer`
+
+### Changes
+
+* `workbench:install` should suggest creating `.env.dusk` equivalent file when `orchestra/testbench-dusk` is installed.
+* Refactor `workbench:install` and add feature tests.
+
+### Removed
+
+* Remove `Orchestra\Workbench\Composer`.
+
 ## 7.13.0
 
 Released: 2024-12-01

diff --git a/src/Console/Concerns/InteractsWithFiles.php b/src/Console/Concerns/InteractsWithFiles.php
@@ -12,6 +12,6 @@ trait InteractsWithFiles
     protected function replaceInFile(Filesystem $filesystem, array|string $search, array|string $replace, string $path): void
     {
         /** @phpstan-ignore argument.type */
-        $filesystem->put($path, str_replace($search, $replace, $filesystem->get($path)));
+        $filesystem->replaceInFile($search, $replace, $path);
     }
 }
diff --git a/src/Console/DevToolCommand.php b/src/Console/DevToolCommand.php
@@ -27,8 +27,6 @@
 #[AsCommand(name: 'workbench:devtool', description: 'Configure Workbench for package development')]
 class DevToolCommand extends Command implements PromptsForMissingInput
 {
-    use Concerns\InteractsWithFiles;
-
     /**
      * Execute the console command.
      *
@@ -194,7 +192,7 @@ protected function appendScriptsToComposer(array $content, Filesystem $filesyste
 
             if (InstalledVersions::isInstalled('laravel/pint')) {
                 $lintScripts[] = '@php vendor/bin/pint --ansi';
-            } elseif ($filesystem->exists(Workbench::packagePath('pint.json'))) {
+            } elseif ($filesystem->isFile(Workbench::packagePath('pint.json'))) {
                 $lintScripts[] = 'pint';
             }
 
@@ -208,8 +206,8 @@ protected function appendScriptsToComposer(array $content, Filesystem $filesyste
         }
 
         if (
-            $filesystem->exists(Workbench::packagePath('phpunit.xml'))
-            || $filesystem->exists(Workbench::packagePath('phpunit.xml.dist'))
+            $filesystem->isFile(Workbench::packagePath('phpunit.xml'))
+            || $filesystem->isFile(Workbench::packagePath('phpunit.xml.dist'))
         ) {
             if (! \array_key_exists('test', $content['scripts'])) {
                 $content['scripts']['test'] = [

diff --git a/src/Console/InstallCommand.php b/src/Console/InstallCommand.php
@@ -22,8 +22,6 @@
 #[AsCommand(name: 'workbench:install', description: 'Setup Workbench for package development')]
 class InstallCommand extends Command implements PromptsForMissingInput
 {
-    use Concerns\InteractsWithFiles;
-
     /**
      * The `testbench.yaml` default configuration file.
      */
@@ -165,7 +163,7 @@ protected function replaceDefaultLaravelSkeletonInTestbenchConfigurationFile(Fil
             return;
         }
 
-        $this->replaceInFile($filesystem, ["laravel: '@testbench'"], ["laravel: '@testbench-dusk'"], join_paths($workingPath, 'testbench.yaml'));
+        $filesystem->replaceInFile(["laravel: '@testbench'"], ["laravel: '@testbench-dusk'"], join_paths($workingPath, 'testbench.yaml'));
     }
 
     /**

diff --git a/tests/Console/Concerns/InteractsWithFilesTest.php b/tests/Console/Concerns/InteractsWithFilesTest.php