Replaced the port selection input with an interactive menu using Spectre.Console. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll pull ASAP and see if I can fix the branches, hopefully some rebasing and squashing will do it. I might need to force push, in that case I'll let you know beforehand. |
|
Fixed. For future reference, I used an interactive rebase so only the right commit was left in each branch. Unfortunately, I'll have to force push for these changes to take effect. |
levimcgomes
force-pushed
the
interactive-menu
branch
from
33bc455 to
8d4195f
Compare
levimcgomes
requested changes
Dec 21, 2024
levimcgomes
approved these changes
Dec 22, 2024
levimcgomes
added a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this works as it's supposed to, since I only have one COM port showing up. Test if possible.
Will close #4
EDIT: I messed up something with the commits and now the CancellationToken is also included in this request and in the interactive menu branch too