Fetch Size and Proxy Client Name Options #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jeandelavarene
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Options to configure JDBC with a default row prefetch, and a proxy client
name.
Added a test to make sure that Oracle R2DBC is actually passing option values
along to JDBC as connection properties.
I noticed that JDBC disables fetch size tuning if set call setFetchSize(0) on
a Statement. Auto-tuning is a nice feature, so Oracle R2DBC won't call setFetchSize
anymore, unless a user passes a non-zero value to the fetchSize method of
an R2DBC Statement.
Replaced references to oracle.jdbc.pool.OracleDataSource with
oracle.jdbc.datasource.impl.OracleDataSource.
Replaced references to the deprecated CONNECTION_PROPERTY_J2EE13_COMPLIANT field
of OracleConnection with the literal String value. Not sure if this field will
actually be removed at some point, but if that does happen then Oracle R2DBC
won't break because of it.
Closes #147 and closes #154