Skip to content

Commit

Permalink
Merge pull request #413 from knshnb/fix-dominated-trials
Browse files Browse the repository at this point in the history
Fix `getDominatedTrials`
  • Loading branch information
c-bata authored Mar 14, 2023
2 parents b7334bf + cd485c1 commit 51f0ddd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion optuna_dashboard/ts/dominatedTrials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const getDominatedTrials = (
const dominatedTrials: boolean[] = []
normalizedValues.forEach((values0: number[], i: number) => {
const dominated = normalizedValues.some((values1: number[], j: number) => {
if (i === j) {
if (i === j || values0.every((v, i) => v == values1[i])) {
return false
}
return values0.every((value0: number, k: number) => {
Expand Down

0 comments on commit 51f0ddd

Please sign in to comment.