Remove use of deprecated method and use the one in CF #438
Conversation
Ao-senXiong
changed the title
|
@wmdietl Please take a look at this PR. |
| if (viewpointAdapter != null) { | ||
| viewpointAdapter.viewpointAdaptConstructor(constructorReturnType, constructorElem, constructorType); | ||
| } | ||
| AnnotatedDeclaredType constructorReturnType = |
There was a problem hiding this comment.
Can you add some comments, e.g. why are we computing and annotating constructorReturnType, even though it's not used later in the method.
There was a problem hiding this comment.
Why is this only necessary for the return type, not the parameter types? The old code also did something with the parameters.
Because other code is in the super call now.
There was a problem hiding this comment.
Which leaves the question why the supermethod isn't doing that... but okay, let's just do it only here.
There was a problem hiding this comment.
I leave a todo there for future clean up.
Sure, deleted the code javadoc |
| @@ -374,47 +376,21 @@ public Boolean visitDeclared(AnnotatedDeclaredType type, Void p) { | |||
| } | |||
| }; | |||
|
|
|||
| /** | |||
| * TODO: Similar but not the same as AnnotatedTypeFactory.constructorFromUse with space set aside from | |||
There was a problem hiding this comment.
Some comment about why this is overridden would still be good.
Co-authored-by: Werner Dietl <[email protected]>
| @@ -70,6 +70,8 @@ | |||
| import com.sun.source.tree.MethodInvocationTree; | |||
| import com.sun.source.tree.NewClassTree; | |||
| import com.sun.source.tree.Tree; | |||
| import org.checkerframework.javacutil.TypesUtils; | |||
There was a problem hiding this comment.
These two imports seem unused. Can they be removed?
If they are needed, can you add them to the org.checkerframework... section earlier in the file?
There was a problem hiding this comment.
Sure, removed. Sometimes we should add spotless to prevent un used import automatically.
There was a problem hiding this comment.
Yes, once we're done with the updates, we should get back to #430.
| if (viewpointAdapter != null) { | ||
| viewpointAdapter.viewpointAdaptConstructor(constructorReturnType, constructorElem, constructorType); | ||
| } | ||
| AnnotatedDeclaredType constructorReturnType = |
There was a problem hiding this comment.
Which leaves the question why the supermethod isn't doing that... but okay, let's just do it only here.
This PR will work on removing old API use and fixes deprecation warnings.