Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4202: Add support for parsing HasIntegerPartEqualTo rule type. #5610

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TanishMoral11
Copy link
Contributor

Fixes #4202 : This PR adds support for parsing the "HasIntegerPartEqualTo" rule type for fractions in the Oppia Android app.

Changes Made

  • Updated test_exp_id_2.json to include the "HasIntegerPartEqualTo" rule type to ensure the rule is tested properly.
  • Updated StateRetriever.kt to handle the "HasIntegerPartEqualTo" rule in the createExactInputForFractionInput() method.
  • Added parsing logic for the "HasIntegerPartEqualTo" rule by adding a new check in createExactInputForFractionInput() to handle this rule type.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@TanishMoral11 TanishMoral11 requested a review from a team as a code owner December 20, 2024 06:01
@TanishMoral11
Copy link
Contributor Author

Hey @adhiamboperes , PTAL !!

Copy link

Coverage Report

Results

Number of files assessed: 1
Overall Coverage: 0.00%
Coverage Analysis: PASS

Exempted coverage

Files exempted from coverage
File Exemption Reason
StateRetriever.ktdomain/src/main/java/org/oppia/android/domain/util/StateRetriever.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fraction type JSONObject Parsing Error
2 participants