-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5070: Display empty answer message in text input interaction #5311
Fix part of #5070: Display empty answer message in text input interaction #5311
Conversation
@BenHenning, PTAL. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed review.
Thanks @Vishwajith-Shettigar! The PR LGTM, but it looks like there are conflicts to resolve. Please update to the latest develop & resolve the conflicts, then assign back once resolved for one final check.
@BenHenning, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @Vishwajith-Shettigar!
Explanation
Fixes part of #5070, In TextInteraction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer.
Created own test suite for text input interaction view.
text_input.webm
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: