Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5070: Display empty answer message in text input interaction #5311

Merged

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Jan 18, 2024

Explanation

Fixes part of #5070, In TextInteraction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer.
Created own test suite for text input interaction view.

text_input.webm

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar Vishwajith-Shettigar changed the title Text input empty answer Fix part of #5070: Display empty answer message in ratio input interaction Jan 18, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar changed the title Fix part of #5070: Display empty answer message in ratio input interaction Fix part of #5070: Display empty answer message in text input interaction Jan 18, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Jan 18, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as ready for review January 19, 2024 17:41
@Vishwajith-Shettigar Vishwajith-Shettigar requested review from a team as code owners January 19, 2024 17:41
@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as draft January 19, 2024 18:02
@Vishwajith-Shettigar
Copy link
Collaborator Author

@BenHenning, PTAL. Thank you.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review.

Thanks @Vishwajith-Shettigar! The PR LGTM, but it looks like there are conflicts to resolve. Please update to the latest develop & resolve the conflicts, then assign back once resolved for one final check.

@Vishwajith-Shettigar
Copy link
Collaborator Author

@BenHenning, PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Vishwajith-Shettigar!

@BenHenning BenHenning merged commit 59a41ab into oppia:develop Mar 4, 2024
36 checks passed
@Vishwajith-Shettigar Vishwajith-Shettigar deleted the text_input_empty_answer branch March 5, 2024 05:17
@Vishwajith-Shettigar Vishwajith-Shettigar restored the text_input_empty_answer branch March 5, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants