-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5283 :Revision cards overlapping. #5289
Conversation
@adhiamboperes, PTAL. |
Hi @Vishwajith-Shettigar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar!
In #5095, these changes were applied for large screens too, Please confirm via screenshots that it displays correctly on tablets.
As a note, the font scaling warning is not in accessibility scanner because of the minLines attribute, also introduced in #5095.
@adhiamboperes, made changes PTAL. |
Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar! LGTM.
Explanation
Fixes #5283, changed wrap_content to fixed width for cardview width.
After Fix, accessibility check not suggesting text scaling( Referencing issue #4736)
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: