Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Revision cards overlapping. #5283

Closed
Vishwajith-Shettigar opened this issue Dec 23, 2023 · 3 comments · Fixed by #5289
Closed

[BUG]: Revision cards overlapping. #5283

Vishwajith-Shettigar opened this issue Dec 23, 2023 · 3 comments · Fixed by #5289
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@Vishwajith-Shettigar
Copy link
Collaborator

Vishwajith-Shettigar commented Dec 23, 2023

Describe the bug

Revision cards overlapping .
PR #5095 causing the issue.

Steps To Reproduce

1.go to any topic
2.click on revision
3.click on any revision card
4.scroll down

Expected Behavior

Cards should be displayed without overlapping.

Screenshots/Videos

concept_card_overlaping

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

No response

@Vishwajith-Shettigar Vishwajith-Shettigar added bug End user-perceivable behaviors which are not desirable. triage needed Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed triage needed labels Dec 23, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Dec 23, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar changed the title [BUG]: Concept cards overlapping in RTL mode [BUG]: Concept cards overlapping. Dec 23, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar changed the title [BUG]: Concept cards overlapping. [BUG]: Revision cards overlapping. Dec 23, 2023
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Dec 23, 2023
@shalenMathew
Copy link

hey, can I contribute to this issue?

@Vishwajith-Shettigar
Copy link
Collaborator Author

hey, can I contribute to this issue?

Hi @shalenMathew, this issue already assigned and has PR, so you can look at other issues.

@adhiamboperes
Copy link
Collaborator

Moving this to 0.12 Release Blockers.

adhiamboperes pushed a commit that referenced this issue Jan 3, 2024
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
Fixes #5283, changed wrap_content to fixed width for cardview width.
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

After Fix, accessibility check not suggesting text scaling( Referencing
issue #4736)

![WhatsApp Image 2023-12-23 at 5 43 08
PM](https://github.com/oppia/oppia-android/assets/76042077/acd91e4d-43fa-4589-b353-7e8d167e4cf0)



## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [ ] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [ ] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [ ] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [ ] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).


## For UI-specific PRs only
| Before| After|
|--------|--------|

|![concept_card_overlaping](https://github.com/oppia/oppia-android/assets/76042077/b76e6a0d-ac11-420c-8c67-2580c27b316c)|
![overlapfix](https://github.com/oppia/oppia-android/assets/76042077/37e24271-8008-4618-97d4-889bc4ff9512)
|

|![cardoverlapbeforetablet](https://github.com/oppia/oppia-android/assets/76042077/c8f8ee4b-26e0-477d-b241-620146bab551)|
![tabletcardoverlap](https://github.com/oppia/oppia-android/assets/76042077/74cdb540-d050-489e-b19f-e8c586780afe)
|


<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

Successfully merging a pull request may close this issue.

3 participants