-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cputemp rrd #8024
base: master
Are you sure you want to change the base?
Fix cputemp rrd #8024
Conversation
-Add sysctl flag to ignore unknown oids -Remove Celsius "C" symbol from output
@awilkin87 can you dump the output of both commands?
|
Sure, here are outputs and exit codes for my system:
|
@awilkin87 can you revert the changes to |
I will test it later tonight, but I believe the |
@awilkin87 looks like you're right, only strip the sed in that case and we should be good. thanks! |
@AdSchellevis I believe the Just to be sure, I reset the rrd. While the file was recreated, it did not contain any temperature readings; only NaN. |
…ysctl collection issue. partially merges #8024
@awilkin87 can you try 8e3b4b7 ? the data needs to be cleansed indeed, but better keep it in php to prevent changing multiple shell commands. |
Remove Celsius symbol from temperature output in PHP code instead of using sed.
@AdSchellevis I tested with preg_replace instead of sed. It works as expected. |
@awilkin87 thanks for confirming, I'll ask @fichtner to slip the change into the next release. |
6586a65
to
607e32a
Compare
This PR addresses Issue #8023, where the CPU temperature graphs stop working after the the recent refactoring.