This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: akihikokuroda <[email protected]>
- Loading branch information
1 parent
c968f76
commit 08e42d4
Showing
4 changed files
with
277 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package updater_test | ||
|
|
||
| import ( | ||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "testing" | ||
| ) | ||
|
|
||
| func TestUpdater(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Updater Suite") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,256 @@ | ||
| package updater_test | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| rukpakv1alpha1 "github.com/operator-framework/rukpak/api/v1alpha1" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| kscheme "k8s.io/client-go/kubernetes/scheme" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
|
|
||
| "github.com/operator-framework/rukpak/internal/updater" | ||
| ) | ||
|
|
||
| var _ = Describe("Updater", func() { | ||
| var ( | ||
| client client.Client | ||
| u updater.Updater | ||
| obj *rukpakv1alpha1.Bundle | ||
| status = &rukpakv1alpha1.BundleStatus{ | ||
| Info: &rukpakv1alpha1.BundleInfo{}, | ||
| Phase: rukpakv1alpha1.PhaseFailing, | ||
| Digest: "digest", | ||
| ObservedGeneration: 1, | ||
| Conditions: []metav1.Condition{ | ||
| { | ||
| Type: "Working", | ||
| Status: metav1.ConditionTrue, | ||
| ObservedGeneration: 3, | ||
| LastTransitionTime: metav1.Time{}, | ||
| Reason: "requested", | ||
| Message: "Working correctly", | ||
| }, | ||
| { | ||
| Type: "starting", | ||
| Status: metav1.ConditionTrue, | ||
| ObservedGeneration: 1, | ||
| LastTransitionTime: metav1.Time{}, | ||
| Reason: "started", | ||
| Message: "starting up", | ||
| }, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| schemeBuilder := runtime.NewSchemeBuilder( | ||
| kscheme.AddToScheme, | ||
| rukpakv1alpha1.AddToScheme, | ||
| ) | ||
| scheme := runtime.NewScheme() | ||
| Expect(schemeBuilder.AddToScheme(scheme)).ShouldNot(HaveOccurred()) | ||
|
|
||
| client = fake.NewClientBuilder().WithScheme(scheme).Build() | ||
| u = updater.New(client) | ||
| obj = &rukpakv1alpha1.Bundle{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "testBundle", | ||
| Namespace: "testNamespace", | ||
| }, | ||
| Spec: rukpakv1alpha1.BundleSpec{ | ||
| ProvisionerClassName: "core.rukpak.io/plain", | ||
| Image: "quay.io/tflannag/olm-plain-bundle:olm-crds-v0.20.0", | ||
| }, | ||
| Status: rukpakv1alpha1.BundleStatus{ | ||
| Info: &rukpakv1alpha1.BundleInfo{}, | ||
| Phase: rukpakv1alpha1.PhaseFailing, | ||
| Digest: "digest", | ||
| ObservedGeneration: 1, | ||
| Conditions: []metav1.Condition{ | ||
| { | ||
| Type: "Working", | ||
| Status: metav1.ConditionTrue, | ||
| ObservedGeneration: 3, | ||
| LastTransitionTime: metav1.Time{}, | ||
| Reason: "requested", | ||
| Message: "Working correctly", | ||
| }, | ||
| { | ||
| Type: "starting", | ||
| Status: metav1.ConditionTrue, | ||
| ObservedGeneration: 1, | ||
| LastTransitionTime: metav1.Time{}, | ||
| Reason: "started", | ||
| Message: "starting up", | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| Expect(client.Create(context.TODO(), obj)).To(Succeed()) | ||
| }) | ||
|
|
||
| When("the object does not exist", func() { | ||
| It("should fail", func() { | ||
| Expect(client.Delete(context.TODO(), obj)).To(Succeed()) | ||
| u.UpdateStatus(updater.EnsureCondition(status.Conditions[0]), updater.EnsureObservedGeneration(status.ObservedGeneration), updater.EnsureBundleDigest(status.Digest), updater.SetBundleInfo(status.Info), updater.SetPhase(status.Phase)) | ||
| err := u.Apply(context.TODO(), obj) | ||
| Expect(err).NotTo(BeNil()) | ||
| Expect(apierrors.IsNotFound(err)).To(BeTrue()) | ||
| }) | ||
| }) | ||
|
|
||
| When("an update is a change", func() { | ||
| It("should apply an update status function", func() { | ||
| u.UpdateStatus(updater.EnsureCondition(metav1.Condition{ | ||
|
|
||
| Type: "Working", | ||
| Status: metav1.ConditionTrue, | ||
| ObservedGeneration: 4, | ||
| LastTransitionTime: metav1.Time{}, | ||
| Reason: "requested", | ||
| Message: "Working correctly", | ||
| })) | ||
| resourceVersion := obj.GetResourceVersion() | ||
|
|
||
| Expect(u.Apply(context.TODO(), obj)).To(Succeed()) | ||
| Expect(client.Get(context.TODO(), types.NamespacedName{Namespace: "testNamespace", Name: "testBundle"}, obj)).To(Succeed()) | ||
| Expect(obj.Status.Conditions).To(HaveLen(2)) | ||
| Expect(obj.GetResourceVersion()).NotTo(Equal(resourceVersion)) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("EnsureBundleDigest", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| }) | ||
|
|
||
| It("should add BundleDigest if not present", func() { | ||
| Expect(updater.EnsureBundleDigest("digest")(status)).To(BeTrue()) | ||
| Expect(status.Digest).To(Equal("digest")) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status.Digest = "digest" | ||
| Expect(updater.EnsureBundleDigest("digest")(status)).To(BeFalse()) | ||
| Expect(status.Digest).To(Equal("digest")) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("EnsureCondition", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
| var condition, anotherCondition metav1.Condition | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| condition = metav1.Condition{Type: "Working"} | ||
| anotherCondition = metav1.Condition{Type: "Completed"} | ||
| }) | ||
|
|
||
| It("should add Condition if not present", func() { | ||
| Expect(updater.EnsureCondition(condition)(status)).To(BeTrue()) | ||
| status.Conditions[0].LastTransitionTime = metav1.Time{} | ||
| Expect(status.Conditions[0]).To(Equal(condition)) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status = &rukpakv1alpha1.BundleStatus{Conditions: []metav1.Condition{condition}} | ||
| Expect(updater.EnsureCondition(condition)(status)).To(BeFalse()) | ||
| Expect(status.Conditions[0]).To(Equal(condition)) | ||
| }) | ||
|
|
||
| It("should add Condition if same type not present", func() { | ||
| status = &rukpakv1alpha1.BundleStatus{Conditions: []metav1.Condition{condition}} | ||
| Expect(updater.EnsureCondition(anotherCondition)(status)).To(BeTrue()) | ||
| status.Conditions[1].LastTransitionTime = metav1.Time{} | ||
| Expect(status.Conditions[1]).To(Equal(anotherCondition)) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("EnsureObservedGeneration", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| }) | ||
|
|
||
| It("should add ObservedGeneration if not present", func() { | ||
| Expect(updater.EnsureObservedGeneration(3)(status)).To(BeTrue()) | ||
| Expect(status.ObservedGeneration).To(Equal(int64(3))) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status.ObservedGeneration = 5 | ||
| Expect(updater.EnsureObservedGeneration(5)(status)).To(BeFalse()) | ||
| Expect(status.ObservedGeneration).To(Equal(int64(5))) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("SetPhase", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| }) | ||
|
|
||
| It("should set phase if not present", func() { | ||
| Expect(updater.SetPhase("phase")(status)).To(BeTrue()) | ||
| Expect(status.Phase).To(Equal("phase")) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status.Phase = "phase" | ||
| Expect(updater.SetPhase("phase")(status)).To(BeFalse()) | ||
| Expect(status.Phase).To(Equal("phase")) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("SetBundleInfo", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
| var info *rukpakv1alpha1.BundleInfo | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| info = &rukpakv1alpha1.BundleInfo{} | ||
| }) | ||
|
|
||
| It("should set phase if not present", func() { | ||
| Expect(updater.SetBundleInfo(info)(status)).To(BeTrue()) | ||
| Expect(status.Info).To(Equal(info)) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status.Info = info | ||
| Expect(updater.SetBundleInfo(info)(status)).To(BeFalse()) | ||
| Expect(status.Info).To(Equal(info)) | ||
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("UnsetBundleInfo", func() { | ||
| var status *rukpakv1alpha1.BundleStatus | ||
| var info *rukpakv1alpha1.BundleInfo | ||
|
|
||
| BeforeEach(func() { | ||
| status = &rukpakv1alpha1.BundleStatus{} | ||
| info = &rukpakv1alpha1.BundleInfo{} | ||
| }) | ||
|
|
||
| It("should set phase if not present", func() { | ||
| Expect(updater.UnsetBundleInfo()(status)).To(BeFalse()) | ||
| Expect(status.Info).To(Equal((*rukpakv1alpha1.BundleInfo)(nil))) | ||
| }) | ||
|
|
||
| It("should return false for no update", func() { | ||
| status.Info = info | ||
| Expect(updater.UnsetBundleInfo()(status)).To(BeTrue()) | ||
| Expect(status.Info).To(Equal((*rukpakv1alpha1.BundleInfo)(nil))) | ||
| }) | ||
| }) |