rebuild env file atomically

quickstart/docker/image/ziti-cli-functions.sh

@@ -390,13 +390,16 @@ function setupEnvironment {
 function persistEnvironmentValues {
   local filepath tmpfilepath retVal envval envvar zEnvVar
   # Get the file path
-  if [[ -n "${ZITI_ENV_FILE:-}" ]]; then
-    filepath="${ZITI_ENV_FILE}"
-  elif (( $# )); then
-    filepath="${1}"
-  else
-    echo -e "$(RED "  --- persistEnvironmentValues() needs a filepath parameter or have ZITI_ENV_FILE set ---")"
-    return 1
+  filepath="${1-}"
+  if [[ "" == "${filepath}" ]]; then
+    _check_env_variable ZITI_ENV_FILE
+    retVal=$?
+    if [[ "${retVal}" != 0 ]]; then
+      echo -e "$(RED "  --- persistEnvironment must take a parameter or have ZITI_ENV_FILE set ---")"
+      return 1
+    else
+      filepath="${ZITI_ENV_FILE}"
+    fi
   fi
 
   # Store all ZITI_ variables in the environment file, creating the directory if necessary