Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute rule signature at rule initialization to save perf #371

Closed
wants to merge 1 commit into from

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Aug 5, 2024

Fix #370

Changes:

  • use a generic class to automatically compute function signature at rule initialization
  • use cached value at "runtime"

@benoit74 benoit74 self-assigned this Aug 5, 2024
@benoit74 benoit74 marked this pull request as ready for review August 5, 2024 12:45
@benoit74 benoit74 requested a review from rgaudin August 5, 2024 12:45
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to discuss alternatives as I find this optimization very intrusive. Haven't dug much into the issue but it looks like what lru_cache is for at first glance.

@benoit74
Copy link
Collaborator Author

benoit74 commented Aug 7, 2024

Replaced by #375

@benoit74 benoit74 closed this Aug 7, 2024
@benoit74 benoit74 deleted the fix_perf_html branch August 9, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue linked to new "extensible" HTML rewriting rules
2 participants