Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic of rewrite mode computation for cases raised in #326 #339

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #326

@benoit74 benoit74 self-assigned this Jun 25, 2024
@benoit74 benoit74 marked this pull request as ready for review June 25, 2024 15:41
@benoit74 benoit74 requested a review from rgaudin June 25, 2024 15:41
@benoit74
Copy link
Collaborator Author

Nota: I checked also few other task I had in mind and which have completed since 2.0.1 release to confirm there are no other known cases for now: https://farm.openzim.org/recipes/100rabbits, https://farm.openzim.org/recipes/website.test.openzim.org_en_all, https://farm.openzim.org/recipes/cloudflare.com_en_learning-center)

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I cannot judge the strategy here.
I think we should have a comment in the code explaining the strategy: why are we not simply relying on mimetype, etc

@benoit74
Copy link
Collaborator Author

Thank you a lot for the remark, I've indeed added documentation (in technical_architecture.md) and opened a discussion with webrecorder to see if we can enhance the situation (things have changed a bit since the original discussions about the WARC-Resource-Type header): webrecorder/browsertrix-crawler#630

@benoit74 benoit74 merged commit cbd431b into main Jun 27, 2024
5 checks passed
@benoit74 benoit74 deleted the fix_rewrite_mode branch June 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some resources rewrite mode are not correctly identified
2 participants