Document wombat settings and change wombat mode to fix major issue of MDN ZIM #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
iframe_rewrite
branch
from
54a4b9e
to
fda56fe
Compare
benoit74
changed the title
benoit74
changed the title
benoit74
force-pushed
the
iframe_rewrite
branch
from
fda56fe
to
6ae8010
Compare
See webrecorder/wombat#155 (comment) for details about why we need to set isSW to false
benoit74
force-pushed
the
iframe_rewrite
branch
from
d0ca1f9
to
9c94b0c
Compare
benoit74
force-pushed
the
iframe_rewrite
branch
from
2436dea
to
161b323
Compare
|
Just bumped to wombat 3.8.6 since it has been released during the night |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293
Fix #239
Fix #333
Changes:
isSWis set tofalse, as recommended by Ilya in warc2zim: rewriting iframe with srcdoc does not work as intended webrecorder/wombat#155 (comment)enable_auto_fetchis set tofalse(not used anyway in our use of wombat, but setting this totrueis a bit misleading)Main concern with merging this is that this breaks the Youtube player, so we should probably wait for a solution to #333=> solved in wombat 3.8.4 which is part of this PROther concern is that is #327 is still not solved by this PR=> this is a distinct and way more tricky problem, especially in terms of implementation