Rename *Url* symbols to *Path*.
#869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirents' "url" are not really url. They are u8 arrays which serve as the main "key". Specification says that this u8 array store a utf-8 encoded string and we use this key as a path. Public API already use path semantic so rename all internal symbols from url to path. Fix #868
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
=======================================
Coverage 58.00% 58.01%
=======================================
Files 101 101
Lines 4622 4623 +1
Branches 1925 1925
=======================================
+ Hits 2681 2682 +1
Misses 667 667
Partials 1274 1274 ☔ View full report in Codecov by Sentry. |
veloman-yunkan
approved these changes
Mar 29, 2024
I've tried. But gcc didn't want. Hope next version of cpp will allow this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dirents' "url" are not really url. They are u8 arrays which serve as the main "key".
Specification says that this u8 array store a utf-8 encoded string and we use this key as a path.
Public API already use path semantic so rename all internal symbols from url to path.
Fix #868