Introduce new getEntryByPathWithNamespace
#859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
changed the title
getEntryByPathWithNsgetEntryByPathWithNamespace
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 57.60% 61.27% +3.67%
==========================================
Files 99 83 -16
Lines 4590 3422 -1168
Branches 1922 1327 -595
==========================================
- Hits 2644 2097 -547
+ Misses 677 435 -242
+ Partials 1269 890 -379 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reiterating my earlier comment - the docstrings of findByPath() and findByTitle() must be updated/corrected, too.
veloman-yunkan
requested changes
Feb 22, 2024
There was a problem hiding this comment.
I guess you missed the text of the previous review:
Reiterating my earlier comment - the docstrings of
findByPath()andfindByTitle()must be updated/corrected, too.
This allow "advanced" tools (as zimdump) to access content in any namespaces, even for new archive.
mgautierfr
force-pushed
the
getEntryByPath_ns
branch
from
351b6f8 to
6054660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #843