Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku build fix #857

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Haiku build fix #857

merged 1 commit into from
Feb 8, 2024

Conversation

Begasus
Copy link
Contributor

@Begasus Begasus commented Feb 8, 2024

Had this patch lying around for a while and with checking up on latest version it still applies, hence a request for a merge. :)

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b243f44) 57.60% compared to head (a713f9d) 57.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   57.60%   57.60%           
=======================================
  Files          99       99           
  Lines        4590     4590           
  Branches     1922     1922           
=======================================
  Hits         2644     2644           
  Misses        677      677           
  Partials     1269     1269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr
Copy link
Collaborator

Thanks a lot for your PR. A small thing, but we would probably never do it ourselves.

@mgautierfr mgautierfr merged commit a7776b3 into openzim:main Feb 8, 2024
30 checks passed
@Begasus
Copy link
Contributor Author

Begasus commented Feb 8, 2024

Thanks for merging, saves the trouble on the next update. +1

@kelson42 kelson42 added this to the 9.2.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants