Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check on all supported macOS versions #832

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Check on all supported macOS versions #832

merged 4 commits into from
Nov 1, 2023

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Oct 28, 2023 •
edited
Loading

Better architecture and system coverage for macOS/iOS related CI

@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13571d7) 57.57% compared to head (e139fc2) 57.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files          98       98           
  Lines        4545     4545           
  Branches     1911     1911           
=======================================
  Hits         2617     2617           
  Misses        668      668           
  Partials     1260     1260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 force-pushed the better-macos-ci branch 4 times, most recently from e0a12c8 to f1056b0 Compare October 29, 2023 11:02
@kelson42 kelson42 requested a review from mgautierfr October 29, 2023 12:30
@kelson42 kelson42 marked this pull request as ready for review October 29, 2023 12:30
@kelson42
Copy link
Contributor Author

@mgautierfr Do you know why a few macOS fail?

@mgautierfr
Copy link
Collaborator

Failling CI is crosscompiling from macos-13 to iOS.
Cross compiling use a "meson_cross_file" file found in https://tmp.kiwix.org/ci/deps2_osx_iOS_x86_64_libzim.tar.xz (step "Install Deps") generated by kiwix-build.
This file tells which compiler to use.

I suppose that this archive is build by kiwix-build for macos-12 and that the binaries paths have changed between macos-12 and macos-13

@kelson42
Copy link
Contributor Author

kelson42 commented Oct 30, 2023 •
edited
Loading

OK, then I would create a dedicated ticket for that scenario and don't do it for the moment. At the release of macOS 15, then it will be a topic.

@kelson42 kelson42 mentioned this pull request Oct 31, 2023
Closed
@kelson42
Copy link
Contributor Author

@mgautierfr @rgaudin macos-13-xlarge (M1) keeps failing, but no log. Wonder what is going on here. Any idea?

@kelson42 kelson42 added this to the 9.0.0 milestone Oct 31, 2023
@rgaudin
Copy link
Member

rgaudin commented Oct 31, 2023

We need units in our account ; that's in the logs

@rgaudin
Copy link
Member

rgaudin commented Oct 31, 2023

I don't recall exactly the message and I'm on my phone but it's something like that. M1 large are supposed to be in beta and free though

@kelson42
Copy link
Contributor Author

@rgaudin I have commented-out the M1 testing as long as whole stuff is in beta. I'm not confortable to rely on an none-prod-ready service.

@kelson42
Copy link
Contributor Author

We are almost good, do you know what trigger the 3 pending macos jobs?

@kelson42 kelson42 merged commit e3316a4 into main Nov 1, 2023
32 checks passed
@kelson42 kelson42 deleted the better-macos-ci branch November 1, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgautierfr mgautierfr Awaiting requested review from mgautierfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kelson42 @mgautierfr @rgaudin