-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to recent googletest framework #830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
=======================================
Coverage 57.57% 57.57%
=======================================
Files 98 98
Lines 4545 4545
Branches 1911 1911
=======================================
Hits 2617 2617
Misses 668 668
Partials 1260 1260 ☔ View full report in Codecov by Sentry. |
Focal has gtest 1.10.0 so we are good here.
Yes. (And also add a minimum version in meson.build) |
@mgautierfr Good, if OK for you, please just fix the last points and merge. |
023e229
to
b6e3b6d
Compare
@mgautierfr @legoktm Package |
b6e3b6d
to
1c7e85c
Compare
@mgautierfr Without feedback from @legoktm I propose to just comment-out or remove buster from the CI. |
Sorry for missing the ping earlier - let's just drop buster support entirely, it's no longer supported by Debian officially, just as part of Debian LTS. |
1c7e85c
to
abfb0e7
Compare
@mgautierfr I don't know why we have two linux CI failing because of libicu. Do you know? Can we merge? |
Fixes #829
The questions left (I see at this time) are: