Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to recent googletest framework #830

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Oct 15, 2023

Fixes #829

The questions left (I see at this time) are:

  • Should we update subproject/gtest
  • Does that not impair compilation on older distributions (in particular focal)

@kelson42 kelson42 requested a review from mgautierfr October 15, 2023 16:45
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3316a4) 57.57% compared to head (419b06f) 57.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files          98       98           
  Lines        4545     4545           
  Branches     1911     1911           
=======================================
  Hits         2617     2617           
  Misses        668      668           
  Partials     1260     1260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 changed the title Add support to recent googltest framework Add support to recent googletest framework Oct 15, 2023
@mgautierfr
Copy link
Collaborator

...TEST_CASE is deprecated since gtest 1.10.0 which was released in 2019.
We had 5 releases of gtest since (especially 1.13.0 for which we had to move to c++14/17).

Does that not impair compilaation on older distributions (in particular focat)

Focal has gtest 1.10.0 so we are good here.

Should we update subproject/gtest

Yes. (And also add a minimum version in meson.build)

@kelson42
Copy link
Contributor Author

@mgautierfr Good, if OK for you, please just fix the last points and merge.

@kelson42 kelson42 force-pushed the latest-gtest-support branch from 023e229 to b6e3b6d Compare October 23, 2023 04:47
@kelson42
Copy link
Contributor Author

@mgautierfr @legoktm Package libgtest-dev has version 1.8.1-3 on Debian Buster, see https://packages.debian.org/source/buster/googletest. But Buster Backports provides version 1.10.0 (which we need) see https://packages.debian.org/source/buster-backports/googletest. @legoktm There is no way you can also add the backport repository in the your Debian Buster Action?

@kelson42 kelson42 force-pushed the latest-gtest-support branch from b6e3b6d to 1c7e85c Compare October 28, 2023 14:32
@kelson42
Copy link
Contributor Author

@mgautierfr Without feedback from @legoktm I propose to just comment-out or remove buster from the CI.

@legoktm
Copy link
Member

legoktm commented Nov 1, 2023

Sorry for missing the ping earlier - let's just drop buster support entirely, it's no longer supported by Debian officially, just as part of Debian LTS.

@kelson42 kelson42 force-pushed the latest-gtest-support branch from 1c7e85c to abfb0e7 Compare November 1, 2023 06:50
@kelson42
Copy link
Contributor Author

kelson42 commented Nov 1, 2023

@mgautierfr I don't know why we have two linux CI failing because of libicu. Do you know? Can we merge?

@kelson42 kelson42 merged commit 2a810ac into main Nov 2, 2023
31 checks passed
@kelson42 kelson42 deleted the latest-gtest-support branch November 2, 2023 20:42
@kelson42 kelson42 modified the milestone: 9.0.0 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile libzim in fresh Ubuntu 22.04
3 participants