Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSV support in --slug #34

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Added CSV support in --slug #34

merged 1 commit into from
Nov 1, 2024

Conversation

josephlewis42
Copy link
Collaborator

Fixes #28

This change makes the scraper more friendly to use in batch mode by mirroring others.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (48c5153) to head (76d267e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   91.66%   91.85%   +0.18%     
==========================================
  Files           4        4              
  Lines         348      356       +8     
  Branches       42       45       +3     
==========================================
+ Hits          319      327       +8     
  Misses         25       25              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephlewis42 josephlewis42 marked this pull request as ready for review November 1, 2024 05:29
@benoit74 benoit74 self-requested a review November 1, 2024 07:56
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit b22b588 into main Nov 1, 2024
8 checks passed
@benoit74 benoit74 deleted the jl/feat/csvs branch November 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CSV in slug CLI parameter
2 participants