Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per-document thumbnail images #8

Closed
josephlewis42 opened this issue Jul 18, 2024 · 2 comments
Closed

Support per-document thumbnail images #8

josephlewis42 opened this issue Jul 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@josephlewis42
Copy link
Collaborator

Devdocs is able to show a documentation set's icon because it compiles them all into a sprite sheet that's referenced by CSS.

All the icons exist in their GitHub repository, but aren't available in the published artifacts.

fcc2zim has functionality today that can fetch a git repo which we could consider repurposing to grab thumbnail icons for the produced ZIM: https://github.com/openzim/freecodecamp/blob/a1221073049895609d7712a8834474311535f0c1/scraper/src/fcc2zim/fetch.py#L12
@josephlewis42 josephlewis42 added the enhancement New feature or request label Jul 18, 2024
@benoit74 benoit74 added this to the later milestone Sep 10, 2024
@josephlewis42
Copy link
Collaborator Author

Duplicate of #29

@josephlewis42 josephlewis42 marked this as a duplicate of #29 Oct 3, 2024
@benoit74
Copy link
Contributor

benoit74 commented Oct 3, 2024

Oups, sorry for having missed this issue when creating the other one ^^

@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
@benoit74 benoit74 mentioned this issue Nov 1, 2024
Open
@benoit74 benoit74 removed this from the later milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephlewis42 @benoit74