-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace default DevDocs illustration by specific language logo #29
Comments
Very supportive of this request. Sounds like a detail, but is not. |
To rephrase this a bit, the feature request is: "would it be possible to automatically use the specific icon used in devdocs for the given slug as ZIM illustration, instead the default DevDocs illustration". |
Quick answer seems to be this is not really possible, the logo displayed on devdocs is way too small. We need a 48x48px, logo is 16x16px, if we upscale it, it is going to be ugly. And placing a 16x16px logo in the middle of a 48x48px (without upscaling, using only 16x16px is going to be weird since it leaves lots of free space). Logos are probably also at https://github.com/freeCodeCamp/devdocs/tree/main/public/icons/docs Here we can find the source where the logo was originally retrieved. I'm afraid this will have to be manually setup for every recipe in the farm. |
Note that implementing #32 will be needed before one can customize the illustration in the Zimfarm |
One idea we've just add is that we can probably automate the creation of a composite icon based on existing ones. We can have a "generic" icon with a placeholder for the 16x16 icons available at https://github.com/freeCodeCamp/devdocs/blob/main/public/icons/docs/ @siemsie do you have any input / feedback / design suggestion to make the icons look better? (we can chat about this on Slack, not sure it is easy to jump into it without context ^^) |
After discussing with @siemsie, we realized there is "only" about 205 icons to create, and it looks like it is totally feasible to create and update them manually and would allow to be more independent from devdocs. So we will give it a try, and must hence implement #32 first, and we can probably live with the default devdocs illustration otherwise. |
Closing this issue for now, we plan to go with #32 only for now (custom icons created "by hand"). Can always be reopened if we change our minds. |
Reopening, because it has also been proposed in #8, so maybe we should consider it. Anyway, not a priority from my PoV. |
Devdocs has the corresponding logos, and seeing how we are likely to end up with dozen up dozen of zim files, it might be helpful to help visually distinguish (beside the zim title, obviously)
The text was updated successfully, but these errors were encountered: