Skip to content

Commit

Permalink
Merge pull request #44 from openzim/coverage-xml
Browse files Browse the repository at this point in the history
Fix coverage upload
  • Loading branch information
benoit74 authored Jun 7, 2024
2 parents 3856ce2 + b141f30 commit a9c5279
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/Tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
if: matrix.python == '3.12'
uses: codecov/codecov-action@v3
with:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}

build_python:
Expand Down
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- Tests workflow now fails CI if the codecov upload step fails

### Fixed

- Coverage invoke task now generating coverage.xml which codecov will upload

## [1.0.1] - 2024-04-19

### Fixed
Expand Down Expand Up @@ -81,7 +91,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Adjust Ruff rules ignored by default
- Use `no-cache-dir` for package install
- Use `no-cache-dir` for package install

## [0.1.4] - 2023-07-17

Expand Down
1 change: 1 addition & 0 deletions tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def report_cov(ctx: Context, *, html: bool = False):
"""report coverage"""
ctx.run("coverage combine", warn=True, pty=use_pty)
ctx.run("coverage report --show-missing", pty=use_pty)
ctx.run("coverage xml", pty=use_pty)
if html:
ctx.run("coverage html", pty=use_pty)

Expand Down

0 comments on commit a9c5279

Please sign in to comment.