Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for CommandBufferCmdEmitter ConvertToCommands #20098

Merged
merged 1 commit into from
Dec 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions xla/service/gpu/runtime/command_buffer_cmd_emitter.h
Original file line number Diff line number Diff line change
@@ -22,10 +22,11 @@ limitations under the License.

namespace xla::gpu {

// Converts thunk sequence to a command buffer cmd sequence. If `force_barrier`
// is true we automatically insert barriers between all commands in a sequence.
// Otherwise we use buffer usage aliasing to allow commands to run concurrently
// and insert barriers only when needed for correctness.
// Converts thunk sequence to a command buffer cmd sequence. If
// `synchronization_mode` is kSerialize, we automatically insert barriers
// between all commands in a sequence. Otherwise we use buffer usage aliasing to
// allow commands to run concurrently and insert barriers only when needed for
// correctness.
absl::StatusOr<CommandBufferCmdSequence> ConvertToCommands(
const ThunkSequence& sequence,
CommandBufferCmdSequence::SynchronizationMode synchronization_mode);