Use std::numeric_limits instead of ComponentStringifyFormat #16372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_666515790
branch
from
fdfedf1
to
062b3c6
Compare
Adding new supported types for the exhaustive tests requires implemented overloads `ComponentStringifyFormat`, but we can write a single implementation that works for all types using `std::numeric_limits` constants and C-style printf `*.*` format specifiers to provide the widths at runtime. PiperOrigin-RevId: 669049658
copybara-service
bot
force-pushed
the
test_666515790
branch
from
062b3c6
to
4670e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::numeric_limits instead of ComponentStringifyFormat
Adding new supported types for the exhaustive tests requires implemented overloads
ComponentStringifyFormat, but we can write a single implementation that works for all types usingstd::numeric_limitsconstants and C-style printf*.*format specifiers to provide the widths at runtime.