PR #16337: [ROCM] disable setting workspace on ROCM #16369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_666501268
branch
2 times, most recently
from
ced13a2
to
c9dfd03
Compare
Imported from GitHub PR #16337 This is a follow-up PR for #16149 which was closed with unmerged commits. Here I disable setting workspace on ROCM. This feature seems to produce sporadic errors because rocblas_set_workspace uses blocking memory functions (e.g. hipMalloc/hipFree) to manipulate scratch memory (which do not work under stream capture). **Disabled** until we have a clear idea on how to make it working on ROCM. @xla-rotation: could you have a look please ? Copybara import of the project: -- 6f42f69 by Pavel Emeliyanenko <[email protected]>: disable workspace Merging this change closes #16337 COPYBARA_INTEGRATE_REVIEW=#16337 from ROCm:ci_rocblas_disable_workspace 6f42f69 PiperOrigin-RevId: 666524181
copybara-service
bot
force-pushed
the
test_666501268
branch
from
c9dfd03
to
119d74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16337: [ROCM] disable setting workspace on ROCM
Imported from GitHub PR #16337
This is a follow-up PR for #16149 which was closed with unmerged commits.
Here I disable setting workspace on ROCM. This feature seems to produce sporadic errors because rocblas_set_workspace uses blocking memory functions (e.g. hipMalloc/hipFree) to manipulate scratch memory (which do not work under stream capture). Disabled until we have a clear idea on how to make it working on ROCM.
@xla-rotation: could you have a look please ?
Copybara import of the project:
--
6f42f69 by Pavel Emeliyanenko [email protected]:
disable workspace
Merging this change closes #16337
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16337 from ROCm:ci_rocblas_disable_workspace 6f42f69