PR #16318: Add handling for general dynamic slice fusion while emitting thunks #16366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_666470987
branch
8 times, most recently
from
f5d60a5
to
c145342
Compare
…ng thunks Imported from GitHub PR #16318 In the current implementation of dynamic slice fusion, we rely on constants or very specific loop offset patterns. This is an effort to generalize this by computing the offset values during compilation and using the constant array as source of offset while emitting thunks. This patch adds support for this in thunks. Next, support for this will be added in the dynamic-slice-fusion-rewriter. Copybara import of the project: -- 936484e by Shraiysh Vaishay <[email protected]>: Add handling for general dynamic slice fusion while emitting thunks In the current implementation of dynamic slice fusion, we rely on constants or very specific loop offset patterns. This is an effort to generalize this by computing the offset values during compilation and using the constant array as source of offset while emitting thunks. This patch adds support for this in thunks. Next, support for this will be added in the dynamic-slice-fusion-rewriter. Merging this change closes #16318 COPYBARA_INTEGRATE_REVIEW=#16318 from shraiysh:general_dynamic_slice_fusion 936484e PiperOrigin-RevId: 668167156
copybara-service
bot
force-pushed
the
test_666470987
branch
from
c145342
to
6691847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16318: Add handling for general dynamic slice fusion while emitting thunks
Imported from GitHub PR #16318
In the current implementation of dynamic slice fusion, we rely on constants or very specific loop offset patterns. This is an effort to generalize this by computing the offset values during compilation and using the constant array as source of offset while emitting thunks.
This patch adds support for this in thunks. Next, support for this will be added in the dynamic-slice-fusion-rewriter.
Copybara import of the project:
--
936484e by Shraiysh Vaishay [email protected]:
Add handling for general dynamic slice fusion while emitting thunks
In the current implementation of dynamic slice fusion, we rely on
constants or very specific loop offset patterns. This is an effort to
generalize this by computing the offset values during compilation and
using the constant array as source of offset while emitting thunks.
This patch adds support for this in thunks. Next, support for this will
be added in the dynamic-slice-fusion-rewriter.
Merging this change closes #16318
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16318 from shraiysh:general_dynamic_slice_fusion 936484e