[xla:collectives] NFC: Remove unused NcclApi CommFinalize function

PiperOrigin-RevId: 702551491
openxla · Dec 4, 2024 · 41910db · 41910db
1 parent 5ad6651
commit 41910db
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 16 deletions.
diff --git a/xla/service/gpu/runtime/nccl_api.cc b/xla/service/gpu/runtime/nccl_api.cc
@@ -302,8 +302,6 @@ class DefaultNcclApi final : public NcclApi {
       absl::Span<const Communicator* const> comms, int32_t color,
       absl::Span<const RankId> keys, std::optional<Config> config) final;
 
-  absl::Status CommFinalize(Communicator* comm) final;
-
   absl::StatusOr<int32_t> CommCount(Communicator* comm) final;
 
   absl::Status GroupStart() final;
@@ -480,11 +478,6 @@ DefaultNcclApi::CommSplit(absl::Span<const Communicator* const> comms,
 #endif  // !defined(TENSORFLOW_USE_ROCM) || TF_ROCM_VERSION >= 60000
 }
 
-absl::Status DefaultNcclApi::CommFinalize(Communicator* comm) {
-  VLOG(1) << "Finalize NCCL communicator: " << comm;
-  return XLA_NCCL_STATUS(ncclCommFinalize(Cast(comm)));
-}
-
 absl::StatusOr<int32_t> DefaultNcclApi::CommCount(Communicator* comm) {
   VLOG(5) << "Get the number of ranks in NCCL communicator: " << comm;
   int32_t count;

diff --git a/xla/service/gpu/runtime/nccl_api.h b/xla/service/gpu/runtime/nccl_api.h
@@ -161,11 +161,6 @@ class NcclApi : public GpuCollectives {
       absl::Span<const Communicator* const> comms, int32_t color,
       absl::Span<const RankId> keys, std::optional<Config> config) = 0;
 
-  // Finalize a communicator object comm.
-  //
-  // https://docs.nvidia.com/deeplearning/nccl/user-guide/docs/api/comms.html#ncclcommdestroy
-  virtual absl::Status CommFinalize(Communicator* comm) = 0;
-
   // Returns the number of ranks in the NCCL communicator comm.
   //
   // https://docs.nvidia.com/deeplearning/nccl/user-guide/docs/api/comms.html#ncclcommcount

diff --git a/xla/service/gpu/runtime/nccl_api_stub.cc b/xla/service/gpu/runtime/nccl_api_stub.cc
@@ -100,10 +100,6 @@ class NcclApiStub final : public NcclApi {
     return UnimplementedError();
   }
 
-  absl::Status CommFinalize(Communicator*) final {
-    return UnimplementedError();
-  }
-
   absl::StatusOr<int32_t> CommCount(Communicator*) final {
     return UnimplementedError();
   }