i18n: change selection style #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mwarning
commented
Sep 23, 2024
•
mwarning
commented
- Do not show english name for selected language to keep selected item shorter.
- Remove select width hack with data-width attribute.
- Also replace drop down arrow with language symbol.
- Handle small screen sizes slightly better.
mwarning
force-pushed
the
language_selection
branch
from
3f00a41 to
f935e0e
Compare
mwarning
changed the title
mwarning
force-pushed
the
language_selection
branch
4 times, most recently
from
0c98c93 to
1bfd9d1
Compare
mwarning
changed the title
|
|
|
Fine with me |
* Remove english name for selected language to keep selected language shorter. * Remove workaround using data-width attribute. * Replace drop down arrow with language symbol. * Handle small screen sizes slightly better. Signed-off-by: Moritz Warning <[email protected]>
mwarning
force-pushed
the
language_selection
branch
from
1bfd9d1 to
588467f
Compare
Signed-off-by: Moritz Warning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.