buildmaster: add static apk utility #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynezz
force-pushed
the
ynezz/add-static-apk
branch
2 times, most recently
from
f18ec34
to
c234fd4
Compare
aparcar
approved these changes
Sep 25, 2024
|
Nice work, thanks for taking care! |
We need a relatively recent `apk` that can sign package indexes. You can find more details in the referenced issue below. However, it has not been released yet and is not available as a prebuilt download. Therefore, until it becomes available, let's build a static version and use that in the meantime. Fixes: a94d4e1 ("add APK signing logic") References: https://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/11008 Signed-off-by: Petr Štetiar <[email protected]>
ynezz
force-pushed
the
ynezz/add-static-apk
branch
from
c234fd4
to
47b8824
Compare
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need apk to sign packages.adb, this is unreleased version introduced in commit ef8c1adb6118 ("apk: switch to index-trust branch"), thus not available already anywhere yet. So until its available, lets build a static version and use that meanwhile.
Fixes: a94d4e1 ("add APK signing logic")