Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master and improve CI #22

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ jobs:
run: |
docker run --detach ${{ matrix.container_test_command }} --name test-${{ matrix.container_flavor }} local/${{ matrix.container_flavor }}
sleep 5
docker logs test-${{ matrix.container_flavor }} | tee ${{ matrix.container_flavor }}.log
grep "${{ matrix.container_verify_string }}" ${{ matrix.container_flavor }}.log
pip install cram
cram --verbose "tests/cram/${{ matrix.container_flavor }}"

deploy:
name: Push Container
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ phase[12]/twistd.*
!.github/**/*
!requirements-dev.txt
!.ruff.toml
!tests
!tests/**/*
1 change: 1 addition & 0 deletions docker/buildmaster/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ RUN \
"buildbot-console-view==$BUILDBOT_VERSION" \
"buildbot-grid-view==$BUILDBOT_VERSION" \
"buildbot-worker==$BUILDBOT_VERSION" \
"twisted==22.10.0" \
pyOpenSSL \
service_identity
RUN \
Expand Down
8 changes: 6 additions & 2 deletions docker/buildmaster/files/entry.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#!/usr/bin/env bash

chown --recursive buildbot:buildbot /master /config /certs
chmod 0700 /master /config /certs
for dir in /master /config /certs; do
[ -d "$dir" ] || continue

chown --recursive buildbot:buildbot "$dir"
chmod 0700 "$dir"
done

/usr/sbin/gosu buildbot /start.sh "$@"
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
cram==0.7
black==23.3.0
ruff==0.0.267
7 changes: 7 additions & 0 deletions tests/cram/master/01-logs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Check that logs have expected content after container startup:

$ docker logs test-master
updating existing installation
creating /master/master.cfg.sample
creating database (sqlite:///state.sqlite)
buildmaster configured in /master
10 changes: 10 additions & 0 deletions tests/cram/worker/01-logs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Check that logs have expected content after container startup:

$ docker logs test-worker
updating existing installation
mkdir /builder/info
Creating info/admin, you need to edit it appropriately.
Creating info/host, you need to edit it appropriately.
Not creating info/access_uri - add it if you wish
Please edit the files in /builder/info appropriately.
worker configured in /builder