UI Updates to Document Data Screen #797
Conversation
- Added warning message text, box, and icon - Showing document data fields according to a specified order defined in the code that matches the slides. Shows remaining fields in an unordered fashion. Tested by: - Manual testing by adding Test eID-Karte Personalausweis - ./gradlew check - ./gradlew connectedCheck Signed-off-by: dritan-x <[email protected]>
| ) | ||
|
|
||
| val sortedKeys = centerAttributes.keys.sortedBy {keyValue-> | ||
| if (keyValue in orderedEntries){ |
There was a problem hiding this comment.
nit: Missing a space after the parenthesis.
| tint = MaterialTheme.colorScheme.background.inverse(), | ||
| contentDescription = stringResource( | ||
| R.string.accessibility_artwork_for, | ||
| stringResource(id = R.string.document_details_screen_title) |
There was a problem hiding this comment.
nit: The warning icon isn't really artwork for the document screen. I don't see any other accessibility text that's a better match... Maybe we need a new string for accessibility, "Warning icon," or something like that?
| ) | ||
| ) | ||
| Text( | ||
| modifier = Modifier.padding(top = 20.dp, bottom = 20.dp, end=5.dp), |
There was a problem hiding this comment.
nit: The end padding looks a little small. From the screenshot, it feels a little tight on the right side, compared to everywhere else. Maybe 16.dp or 20.dp, so it's closer to the top/bottom?
| "family_name", | ||
| ) | ||
|
|
||
| val sortedKeys = centerAttributes.keys.sortedBy {keyValue-> |
There was a problem hiding this comment.
nit: I think we'd normally put spaces around keyValue here?
| ) { | ||
| Row( | ||
| modifier = Modifier | ||
| .padding(horizontal = 30.dp) |
There was a problem hiding this comment.
nit: It looks like all the elements on the screen should be indented from the left so they line up with this box. Maybe move this from this Row to the Column that contiains everything?
Tested by: