CredentialTypeRepository implementation in VerifierApp #436
Conversation
RequestDocument obtains content from the CredentialTypeRepository Display names/values from the CredentialTypeRepository when showing the document added methods to get specific MdocCredentialTypes and MdocDataElements Signed-off-by: Kees Geluk <[email protected]>
identity/src/main/java/com/android/identity/credentialtype/CredentialTypeRepository.kt
Show resolved
Hide resolved
| it.dataElements.associateBy { el -> el.attribute.identifier }.toMap() | ||
| ) | ||
| }.toMap() | ||
| } |
There was a problem hiding this comment.
So we're keeping an extra set of data elements in this class, in addition to each type? This seems wrong.
But more, importantly, I don't think getMdocDataElement() should be on the repository in the first place. Why not put it on MdocCredentialType and then add a lookup function for mDL doctype so the code becomes:
val mdocCredentialType = repo.getMdocCredentialType(docType)
val mdocDataElement = mdocCredentialType?.getMdocDataElement(namespaceName, dataElementName)
(Also, would like both get*() functions to be O(1) .. that is, use a hashtable, not a list)
There was a problem hiding this comment.
I changed the Lists to Map in the context of the MdocCredentialType. In the context of the overall CredentialType the usage of a Map is arbitrary. The key could be the mdoc doctype , but also a VC Credential Type, so I kept a here a List and added a method to lookup the VC Credential Type.
There was a problem hiding this comment.
By changing the Lists to Maps, a separate method getMdocElements is not needed anymore
- changes in documentation - refactoring Lists to Maps Signed-off-by: Kees Geluk <[email protected]>
Fixes #401