Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to workflow run in scorecard #655

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Add context to workflow run in scorecard #655

merged 1 commit into from
Nov 23, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Nov 23, 2024 •
edited
Loading

Describe your changes

I need information about the workflow execution context in order to identify any points for improvement.

Its behaviour still doesn't make sense.

Checklist before requesting a review

  • I checked that all workflows return a success.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I followed the Conventional Commit spec.

Maintainer tasks

  • Label as either: bug, ci, docker, documentation, enhancement.
  • Sign unsigned commits.

@claudioandre-br claudioandre-br added the ci Continuous integration and/or continuous delivery label Nov 23, 2024
@claudioandre-br
ci(scorecard): add context to workflow run (openwall#655)
419eb9f 
I need information about the workflow execution context in order to
identify any points for improvement.

Signed-off-by: Claudio André <[email protected]>
github-actions[bot]
github-actions bot approved these changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

@claudioandre-br
Copy link
Member Author

bot: MERGE status

@github-actions GitHub Actions
Copy link 

🤖: status
- reviewDecision: APPROVED ✔
- mergeStateStatus: BLOCKED ❌

@claudioandre-br claudioandre-br merged commit 419eb9f into openwall:main Nov 23, 2024
10 checks passed
@claudioandre-br
Copy link
Member Author

claudioandre-br commented Nov 23, 2024 •
edited
Loading

I'll revert this and move the logic to Trivy.

  • scorecard job must only have steps with uses

The jobs were ignored for some unknown reason (from Dependabot PR).
image

@claudioandre-br claudioandre-br deleted the feat/addDebug branch November 23, 2024 15:00
claudioandre-br added a commit to claudioandre-br/john-packages that referenced this pull request Nov 23, 2024
@claudioandre-br
revert: ci(scorecard): add context to workf.. (openwall#656)
b8f316a 
This reverts commit 419eb9f.

The scorecard action is very restrictive in terms of what it accepts
to be done

So I'm reverting openwall#655.

Signed-off-by: Claudio André <[email protected]>
@claudioandre-br claudioandre-br mentioned this pull request Nov 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
ci Continuous integration and/or continuous delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claudioandre-br