Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint all files in code base #639

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Nov 21, 2024

Describe your changes

Validate all files in code base.

Checklist before requesting a review

  • I checked that all workflows return a success.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I followed the Conventional Commit spec.

Maintainer tasks

  • Label as either: bug, ci, docker, documentation, enhancement.
  • Sign unsigned commits.

@claudioandre-br claudioandre-br added the ci Continuous integration and/or continuous delivery label Nov 21, 2024
@claudioandre-br
Copy link
Member Author

TDD: failed as expected.

claudioandre-br added a commit to claudioandre-br/john-packages that referenced this pull request Nov 21, 2024
Validate all files in code base.

Signed-off-by: Claudio André <[email protected]>
@claudioandre-br
Copy link
Member Author

All except this one are ok:

  • Explicitly specified pattern "/github/workspace/snapcraft.yaml" is a symbolic link.

A fix should be provided by upstream.

claudioandre-br added a commit to claudioandre-br/john-packages that referenced this pull request Nov 22, 2024
Validate all files in code base.

Signed-off-by: Claudio André <[email protected]>
claudioandre-br added a commit to claudioandre-br/john-packages that referenced this pull request Nov 22, 2024
Validate all files in code base.

Signed-off-by: Claudio André <[email protected]>
@claudioandre-br
Copy link
Member Author

claudioandre-br commented Nov 22, 2024

It is really odd that it is validating based on something that vanished days ago:

.cache/trivy/policy/content/policies/cloud/policies/aws/ecs/no_plaintext_secrets.yaml (secrets)
===============================================================================================
Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 1)

CRITICAL: AWS (aws-access-key-id)
════════════════════════════════════════
AWS Access Key ID
────────────────────────────────────────
 .cache/trivy/policy/content/policies/cloud/policies/aws/ecs/no_plaintext_secrets.yaml:57
────────────────────────────────────────
  55                 - Environment:
  56                     - Name: AWS_ACCESS_KEY_ID
  57 [                     Value: ********************
  58                   Image: cfsec/cfsec:latest
────────────────────────────────────────

Ping #616

claudioandre-br added a commit to claudioandre-br/john-packages that referenced this pull request Nov 22, 2024
Validate all files in code base.

Signed-off-by: Claudio André <[email protected]>
Validate all files in code base.

Signed-off-by: Claudio André <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

@claudioandre-br
Copy link
Member Author

bot: MERGE

@claudioandre-br
Copy link
Member Author

bot: MERGE status

Copy link

🤖: status
- reviewDecision: APPROVED ✔
- mergeStateStatus: BLOCKED ❌

@claudioandre-br
Copy link
Member Author

bot: MERGE skip

Copy link

🤖: status
- reviewDecision: APPROVED ✔
- mergeStateStatus: BLOCKED ❌

@claudioandre-br claudioandre-br merged commit 9682523 into openwall:main Nov 23, 2024
10 checks passed
@claudioandre-br claudioandre-br deleted the feat/lintAll branch November 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration and/or continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant