-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint all files in code base #639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDD: failed as expected. |
claudioandre-br
added a commit
to claudioandre-br/john-packages
that referenced
this pull request
Nov 21, 2024
Validate all files in code base. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
feat/lintAll
branch
from
November 21, 2024 16:13
a924ebd
to
c923591
Compare
All except this one are ok:
A fix should be provided by upstream. |
claudioandre-br
added a commit
to claudioandre-br/john-packages
that referenced
this pull request
Nov 22, 2024
Validate all files in code base. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
feat/lintAll
branch
from
November 22, 2024 11:06
c923591
to
0175412
Compare
claudioandre-br
added a commit
to claudioandre-br/john-packages
that referenced
this pull request
Nov 22, 2024
Validate all files in code base. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
feat/lintAll
branch
from
November 22, 2024 11:11
0175412
to
8f2885b
Compare
It is really odd that it is validating based on something that vanished days ago:
Ping #616 |
claudioandre-br
added a commit
to claudioandre-br/john-packages
that referenced
this pull request
Nov 22, 2024
Validate all files in code base. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
feat/lintAll
branch
from
November 22, 2024 14:37
8f2885b
to
54600fb
Compare
Validate all files in code base. Signed-off-by: Claudio André <[email protected]>
claudioandre-br
force-pushed
the
feat/lintAll
branch
from
November 23, 2024 13:52
54600fb
to
9682523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved PR
bot: MERGE |
bot: MERGE status |
|
bot: MERGE skip |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Validate all files in code base.
Checklist before requesting a review
Maintainer tasks
bug
,ci
,docker
,documentation
,enhancement
.